Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Create pre-release workflow #13513

Merged
merged 1 commit into from
Jan 27, 2024
Merged

[ci] Create pre-release workflow #13513

merged 1 commit into from
Jan 27, 2024

Conversation

titusfortner
Copy link
Member

Description

This CI job can only be run manually; has a text input for version number and a checkbox for whether it uses Beta channel (beta on the "Early Stable Release" day has always been the same build number as the Stable Release several days later).
workflow_dispatch

Running this on current code with the current Beta CDP (122)
looks like this: https://github.com/titusfortner/selenium/actions/runs/7661130480/job/20880319510
and results in this:
titusfortner#58

Motivation and Context

The previous release process didn't handle the Rust version -> SM build -> prep process correctly.
There's no good way to do that with a Rake task, so I created this github workflow to do it.

This is also nice because you can kick it off and it will automatically run the tests.
While the tests are running:

  1. Verify the files all look correct
  2. Pull the PR (gh pr checkout 12345), make the updates to the changelogs and push them back to the pr and merge it

Then all that is left is to run: ./go all:release and it should finish doing everything

@titusfortner titusfortner added the C-build Build related issues (bazel and CI) label Jan 25, 2024
.github/workflows/ci-rust.yml Outdated Show resolved Hide resolved
@titusfortner
Copy link
Member Author

I'm doing a few things wrong with this one, it'll be better once #13516 is merged.

@titusfortner
Copy link
Member Author

Ok, this has been updated to use v4 actions, and makes sure inputs are strings not booleans, because booleans confuse bash.

I re-ran it on my fork:
https://github.com/titusfortner/selenium/actions/runs/7673663697/job/20917198122

this is the PR:
titusfortner#58

I'm going to merge it once tests pass; let me know if there are any concerns or things I can change.

@titusfortner titusfortner merged commit 036b613 into trunk Jan 27, 2024
10 checks passed
@titusfortner titusfortner deleted the pre_release_ci branch January 27, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-build Build related issues (bazel and CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants