Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly export Select and WebDriverWait from selenium.webdriver.support.ui #13491

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Explicitly export Select and WebDriverWait from selenium.webdriver.support.ui #13491

merged 2 commits into from
Mar 26, 2024

Conversation

adamtheturtle
Copy link
Contributor

Motivation and Context

Without this, mypy in strict mode gives:

Module "selenium.webdriver.support.ui" does not explicitly export attribute "Select"  [attr-defined]

when following the documentation at https://selenium-python.readthedocs.io/navigating.html#filling-in-forms.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (96e1411) 58.48% compared to head (2340a8d) 58.48%.
Report is 15 commits behind head on trunk.

❗ Current head 2340a8d differs from pull request most recent head c537ac0. Consider uploading reports for the commit c537ac0 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #13491   +/-   ##
=======================================
  Coverage   58.48%   58.48%           
=======================================
  Files          86       86           
  Lines        5270     5271    +1     
  Branches      220      220           
=======================================
+ Hits         3082     3083    +1     
  Misses       1968     1968           
  Partials      220      220           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

adamtheturtle and others added 2 commits March 26, 2024 11:49
…pport.ui

Without this, `mypy` in strict mode gives:

```
Module "selenium.webdriver.support.ui" does not explicitly export attribute "Select"  [attr-defined]
```

when following the documentation at https://selenium-python.readthedocs.io/navigating.html#filling-in-forms.
@diemol diemol merged commit fccfed1 into SeleniumHQ:trunk Mar 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants