Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Remove circular dependency when using RemoteWebElement in BiDi classes #13463

Merged
merged 8 commits into from
Mar 13, 2024

Conversation

pujagani
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Bazel circular dependency was introduced when trying to create user-friendly methods in BrowsingContext to return web elements when locateNodes is called. This is crucial for porting from Classic to BiDi in future.
I foresee the same problem will occur when porting.

I understand the PR is big, but essentially it is grouping classes in packages and adding BUILD.bazel files to it. This is also the recommended practice based on Bazel documentation https://bazel.build/configure/best-practices#packages.

I understand this is a breaking change due to a change in package structure. But I am not sure how to proceed further.
From user perspective, they will need to update their imports.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.48%. Comparing base (77521cc) to head (0d87bba).
Report is 1 commits behind head on trunk.

❗ Current head 0d87bba differs from pull request most recent head 3fa8e93. Consider uploading reports for the commit 3fa8e93 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #13463   +/-   ##
=======================================
  Coverage   58.48%   58.48%           
=======================================
  Files          86       86           
  Lines        5270     5270           
  Branches      220      220           
=======================================
  Hits         3082     3082           
  Misses       1968     1968           
  Partials      220      220           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pujagani pujagani force-pushed the circular-dep-bidi branch from 77fd3d4 to cc8118d Compare March 7, 2024 07:46
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think people know this is a beta (or even alpha) so breaking changes are expected.

Perhaps we need a quick blog post.

@pujagani
Copy link
Contributor Author

pujagani commented Mar 7, 2024

Thank you!
Okay, I will write one up, add a link here, and then merge the changes.

@pujagani pujagani force-pushed the circular-dep-bidi branch from 54a65a6 to b991a2e Compare March 13, 2024 04:48
@pujagani
Copy link
Contributor Author

Blog post PR SeleniumHQ/seleniumhq.github.io#1608

@pujagani pujagani merged commit eddd906 into SeleniumHQ:trunk Mar 13, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants