-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] Remove circular dependency when using RemoteWebElement in BiDi classes #13463
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13463 +/- ##
=======================================
Coverage 58.48% 58.48%
=======================================
Files 86 86
Lines 5270 5270
Branches 220 220
=======================================
Hits 3082 3082
Misses 1968 1968
Partials 220 220 ☔ View full report in Codecov by Sentry. |
77fd3d4
to
cc8118d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think people know this is a beta (or even alpha) so breaking changes are expected.
Perhaps we need a quick blog post.
Thank you! |
54a65a6
to
b991a2e
Compare
Blog post PR SeleniumHQ/seleniumhq.github.io#1608 |
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Bazel circular dependency was introduced when trying to create user-friendly methods in BrowsingContext to return web elements when
locateNodes
is called. This is crucial for porting from Classic to BiDi in future.I foresee the same problem will occur when porting.
I understand the PR is big, but essentially it is grouping classes in packages and adding BUILD.bazel files to it. This is also the recommended practice based on Bazel documentation https://bazel.build/configure/best-practices#packages.
I understand this is a breaking change due to a change in package structure. But I am not sure how to proceed further.
From user perspective, they will need to update their imports.
Motivation and Context
Types of changes
Checklist