Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Restore rust flags for build SM in CI #13281

Merged
merged 1 commit into from
Dec 11, 2023
Merged

[ci] Restore rust flags for build SM in CI #13281

merged 1 commit into from
Dec 11, 2023

Conversation

bonigarcia
Copy link
Member

Description

This PR adds the flags -Ctarget-feature=+crt-static to build SM in Windows and macOS. They are not required in Linux since we use target x86_64-unknown-linux-musl, which already provides static linking.

Motivation and Context

To avoid problems like the reported in #13261.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bonigarcia bonigarcia added C-build Build related issues (bazel and CI) C-rust labels Dec 11, 2023
@bonigarcia bonigarcia merged commit 2d73f13 into trunk Dec 11, 2023
13 checks passed
@bonigarcia bonigarcia deleted the sm_build_flags branch December 11, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-build Build related issues (bazel and CI) C-rust
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants