-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rb] Extend RBS support for logger and log entry #13192
Conversation
…nto rb-update-logger-types
The Logger class does not actually use the LogEntry class, so these are actually unrelated. That said, if this fixes an error, we might as well get it merged, thanks! |
So the way I'm expanding RBS support is just by looking at the result of the Steep check and fixed the issues, My idea is to continue updating the type support in small PRs, containing two or three classes, so eventually when 'steep check' is run, there are no type issues |
* Extend RBS support for logger and log entry * Update allowed to match the instance type * Change as_json to untyped and nillable --------- Co-authored-by: aguspe <[email protected]> Co-authored-by: Titus Fortner <[email protected]>
Description
This PR expands RBS support for the following classes:
It also adds support for the standard library 'Forwardable' on the Steepfile
After the update on the RBS files for the LogEntry class this is the result:
The logger class keeps producing an error due to the proc signature coming from logger.formatted = not being identified, even though is part of the standard library:
Motivation and Context
This change expands the work done on: #12844
The main motivation behind it comes from: #10943
Types of changes
Checklist