Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rb] Extend RBS support for logger and log entry #13192

Merged
merged 9 commits into from
Nov 27, 2023

Conversation

aguspe
Copy link
Contributor

@aguspe aguspe commented Nov 23, 2023

Description

This PR expands RBS support for the following classes:

  • Selenium::Webdriver::LogEntry
  • Selenium::Webdriver::Logger

It also adds support for the standard library 'Forwardable' on the Steepfile

After the update on the RBS files for the LogEntry class this is the result:

Screenshot 2023-11-23 at 15 11 32

The logger class keeps producing an error due to the proc signature coming from logger.formatted = not being identified, even though is part of the standard library:

Screenshot 2023-11-23 at 15 43 07

Motivation and Context

This change expands the work done on: #12844

The main motivation behind it comes from: #10943

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aguspe aguspe changed the title Extend RBS support for logger and log entry [rb] Extend RBS support for logger and log entry Nov 24, 2023
@titusfortner
Copy link
Member

The Logger class does not actually use the LogEntry class, so these are actually unrelated. That said, if this fixes an error, we might as well get it merged, thanks!

@titusfortner titusfortner added this to the 4.16 milestone Nov 27, 2023
@aguspe
Copy link
Contributor Author

aguspe commented Nov 27, 2023

The Logger class does not actually use the LogEntry class, so these are actually unrelated. That said, if this fixes an error, we might as well get it merged, thanks!

So the way I'm expanding RBS support is just by looking at the result of the Steep check and fixed the issues,
I did these two classes together just because they appeared in alphabetical order

My idea is to continue updating the type support in small PRs, containing two or three classes, so eventually when 'steep check' is run, there are no type issues

@titusfortner titusfortner merged commit 36585d1 into SeleniumHQ:trunk Nov 27, 2023
30 checks passed
LogicOscar pushed a commit to LogicOscar/selenium that referenced this pull request Nov 29, 2023
* Extend RBS support for logger and log entry

* Update allowed to match the instance type

* Change as_json to untyped and nillable

---------

Co-authored-by: aguspe <[email protected]>
Co-authored-by: Titus Fortner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants