Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Use stable-i686-pc-windows-msvc target for release SM binary in Windows #13134

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

bonigarcia
Copy link
Member

Description

This PR reverts the use of stable-i686-pc-windows-gnu for the stable release of SM in Windows, and it uses stable-i686-pc-windows-msvc instead.

Motivation and Context

That target was changed since stable-i686-pc-windows-gnu is required to build the SM binary with debug symbols. But it seems this new binary is detected as malware by some antivirus, as reported in #13130. Therefore, we can use stable-i686-pc-windows-msvc for the release SM in Windows (which seems safer for antivirus) and stable-i686-pc-windows-gnu for debug (only used for particular troubleshooting uses).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bonigarcia bonigarcia added C-rust C-build Build related issues (bazel and CI) labels Nov 10, 2023
@titusfortner titusfortner merged commit b0497bf into trunk Nov 10, 2023
16 checks passed
@titusfortner titusfortner deleted the sm_msvc_target_win branch November 10, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-build Build related issues (bazel and CI) C-rust
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants