Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Deprecate saving screenshots with different image formats #12878

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

nvborisenko
Copy link
Member

Description

This is the 1st phase of out journey to remove System.Drawing.Common dependency.

Motivation and Context

Any great library should keep number of dependencies minimized as possible.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nvborisenko
Copy link
Member Author

Enabler for #12781

Copy link
Member

@titusfortner titusfortner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I offered suggestions that match how we say it in Ruby, feel free to keep or change.

dotnet/src/webdriver/Screenshot.cs Outdated Show resolved Hide resolved
dotnet/src/webdriver/Screenshot.cs Outdated Show resolved Hide resolved
@titusfortner titusfortner merged commit c8e93aa into SeleniumHQ:trunk Oct 5, 2023
3 checks passed
aguspe pushed a commit to aguspe/selenium that referenced this pull request Oct 22, 2023
…eleniumHQ#12878)

* Deprecate saving screenshots with different image formats

---------

Co-authored-by: Titus Fortner <[email protected]>
@nvborisenko nvborisenko deleted the dotnet-image-deprecation branch November 10, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants