Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rust] Avoids resolving symbolic links and consider the cache might not be writable #12877

Merged
merged 10 commits into from
Oct 5, 2023
Merged

[rust] Avoids resolving symbolic links and consider the cache might not be writable #12877

merged 10 commits into from
Oct 5, 2023

Conversation

bonigarcia
Copy link
Member

Description

The aim of this PR is three-folded:

Motivation and Context

Part of the development of SM 0.4.14.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bonigarcia bonigarcia added this to the 4.14 milestone Oct 5, 2023
bonigarcia referenced this pull request Oct 5, 2023
@bonigarcia
[rust] Clean logic for checking driver version
5e2972e
@titusfortner titusfortner merged commit d13ac33 into trunk Oct 5, 2023
63 of 66 checks passed
@titusfortner titusfortner deleted the sm_canon_win branch October 5, 2023 19:43
aguspe pushed a commit to aguspe/selenium that referenced this pull request Oct 22, 2023
@bonigarcia @aguspe
[rust] Avoids resolving symbolic links and consider the cache might n…
5d9b711 
…ot be writable (SeleniumHQ#12877)

* [rust] Canonicalize paths only in Windows

* [rust] Warning if writing metadata is not possible

* [rust] Fix condition for displaying warning due to incompatible version

* [rust] Warning when cache path cannot be created

* [rust] Make metadata optional

* [rust] Improve warning messages

* [rust] Clean function to write metadata

* [rust] Rename path buf function

* [rust] Fix logic related to checking driver version (broken in 5e2972e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-rust
Projects
Selenium Manager
Status: Done
Milestone
4.14
Development

Successfully merging this pull request may close these issues.
2 participants
@bonigarcia @titusfortner