Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] Fix config setup in Selenium Manager #12807

Merged
merged 5 commits into from
Sep 24, 2023
Merged

[rust] Fix config setup in Selenium Manager #12807

merged 5 commits into from
Sep 24, 2023

Conversation

bonigarcia
Copy link
Member

Description

This PR fixes the logic for reading the configuration file and envs in Selenium Manager.

Motivation and Context

This PR should fix #12789 and #12782.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bonigarcia bonigarcia added this to the 4.13 milestone Sep 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fb358a4) 56.53% compared to head (77acf32) 56.53%.
Report is 2 commits behind head on trunk.

❗ Current head 77acf32 differs from pull request most recent head 81962e2. Consider uploading reports for the commit 81962e2 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12807   +/-   ##
=======================================
  Coverage   56.53%   56.53%           
=======================================
  Files          86       86           
  Lines        5253     5253           
  Branches      187      187           
=======================================
  Hits         2970     2970           
  Misses       2096     2096           
  Partials      187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@titusfortner
Copy link
Member

Looks good, but I'm not merging any code until we get the CI happy again.

@titusfortner titusfortner merged commit 553791c into trunk Sep 24, 2023
56 of 63 checks passed
@titusfortner titusfortner deleted the sm_fix_config branch September 24, 2023 20:33
@vivin-joghee
Copy link

Issue #12788 is still not fixed in Selenium version 4.16.0 (selenium-manager 0.4.16). However, the comment in the issue #12788 says that it is fixed in selenium 4.13. Can you please help to double check. I’m using REDHAT 8.4.

@titusfortner
Copy link
Member

@vivin-joghee can you paste the reproducible code, error/stack trace and Log output in that issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Selenium Manager does not use documented config file or environment variables
4 participants