Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dotnet] Use correct Newtonsoft.Json 11.0.1 as minimum required #12776

Merged
merged 1 commit into from
Sep 19, 2023
Merged

[dotnet] Use correct Newtonsoft.Json 11.0.1 as minimum required #12776

merged 1 commit into from
Sep 19, 2023

Conversation

nvborisenko
Copy link
Member

Description

This is continuation of #12772

Motivation and Context

Using newtonsoft 5.0.1 is incorrect. We can safely use 11.0.1 because it's minimum required version.
Why:

  • this version introduced support of netstandard 2.0
  • our code is still compatible

We can even use lower versions... but let's postpone it for now.

PS: I tested final package.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@titusfortner titusfortner merged commit fbfaab5 into SeleniumHQ:trunk Sep 19, 2023
10 of 13 checks passed
@nvborisenko nvborisenko deleted the dotnet-newtonsoft branch September 20, 2023 09:03
titusfortner pushed a commit that referenced this pull request Sep 25, 2023
Revert "[dotnet] Use correct Newtonsoft.Json 11.0.1 as minimum requir…
f65f0d5 
…ed (#12776)"

This reverts commit fbfaab5.
@titusfortner titusfortner mentioned this pull request Sep 25, 2023
Merged
titusfortner added a commit that referenced this pull request Sep 25, 2023
@titusfortner
Revert "[dotnet] Use correct Newtonsoft.Json 11.0.1 as minimum requir…
35edea6 
…ed (#12776)"

This reverts commit fbfaab5.
titusfortner added a commit that referenced this pull request Sep 25, 2023
@titusfortner
Restore required version of Newtonsoft to 13.0.1 (#12817)
bf4b286 
* Revert "[dotnet] Use correct Newtonsoft.Json 11.0.1 as minimum required (#12776)"

This reverts commit fbfaab5.

* Revert "[dotnet] Use the lower version of Newtonsoft.Json as dependency (#12772)"

This reverts commit 6e33959.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvborisenko @titusfortner