Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Use new 'getArray' method to extract driver configurations #12716

Merged
merged 2 commits into from
Oct 7, 2023

Conversation

sbabcoc
Copy link
Contributor

@sbabcoc sbabcoc commented Sep 10, 2023

Description

In this PR, I eliminate the need to deal with Config.DELIMITER by using the new getArray method.

Motivation and Context

This specific implementation was the original motivation for a series of PRs to introduce an unambiguous delimiter into flat lists of associated settings. My previous PR added the Config.getArray method, which returns delimited lists of associated settings as a list of lists, eliminating the need for client code to perform this operation.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sbabcoc sbabcoc force-pushed the pr/use-new-getArray-method branch 3 times, most recently from 7457789 to 5976220 Compare September 11, 2023 19:36
@sbabcoc sbabcoc changed the title Use new 'getArray' method; fix formatting Use new 'getArray' method to extract driver configurations Sep 11, 2023
@sbabcoc sbabcoc force-pushed the pr/use-new-getArray-method branch 8 times, most recently from 09cd7d0 to 10df5be Compare September 16, 2023 15:04
@sbabcoc sbabcoc changed the title Use new 'getArray' method to extract driver configurations [java] Use new 'getArray' method to extract driver configurations Sep 16, 2023
@sbabcoc sbabcoc force-pushed the pr/use-new-getArray-method branch 13 times, most recently from efb2423 to 66347a8 Compare September 19, 2023 15:29
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (33c4122) 56.51% compared to head (af46dbb) 56.51%.

❗ Current head af46dbb differs from pull request most recent head 54caf4c. Consider uploading reports for the commit 54caf4c to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12716   +/-   ##
=======================================
  Coverage   56.51%   56.51%           
=======================================
  Files          86       86           
  Lines        5255     5255           
  Branches      187      187           
=======================================
  Hits         2970     2970           
  Misses       2098     2098           
  Partials      187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbabcoc sbabcoc force-pushed the pr/use-new-getArray-method branch 3 times, most recently from 9f72953 to bc68a0d Compare September 20, 2023 15:30
@sbabcoc sbabcoc force-pushed the pr/use-new-getArray-method branch 5 times, most recently from c388f7f to 2e1338b Compare September 26, 2023 06:11
@krmahadevan
Copy link
Contributor

@sbabcoc - If this implementation is ready to be reviewed, maybe you can help add a test to this as well and drop a message. If it's still WIP maybe you could have this PR in draft ?

@sbabcoc
Copy link
Contributor Author

sbabcoc commented Sep 26, 2023

@krmahadevan This is ready for review. The existing unit tests cover these revisions.

@sbabcoc sbabcoc force-pushed the pr/use-new-getArray-method branch 4 times, most recently from ed9783c to ca81b92 Compare September 27, 2023 15:34
@pujagani pujagani requested a review from diemol September 29, 2023 05:49
@sbabcoc sbabcoc force-pushed the pr/use-new-getArray-method branch 11 times, most recently from e721134 to 5155821 Compare October 5, 2023 20:26
@sbabcoc sbabcoc force-pushed the pr/use-new-getArray-method branch from 5155821 to 54caf4c Compare October 5, 2023 22:20
@diemol diemol merged commit ecfa9c4 into SeleniumHQ:trunk Oct 7, 2023
3 checks passed
@sbabcoc sbabcoc deleted the pr/use-new-getArray-method branch October 7, 2023 07:18
aguspe pushed a commit to aguspe/selenium that referenced this pull request Oct 22, 2023
…leniumHQ#12716)

Use new 'getArray' method; fix formatting

Co-authored-by: Diego Molina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants