[js] do not need browser version if Selenium is managing it #12641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diemol
reviewed
Aug 30, 2023
| @@ -70,7 +70,8 @@ function driverLocation(options) { | |||
| let args = ['--browser', options.getBrowserName(), '--output', 'json'] | |||
|
|
|||
| if (options.getBrowserVersion() && options.getBrowserVersion() !== '') { | |||
| args.push('--browser-version', options.getBrowserVersion()) | |||
| args.push('--browser-version', options.getBrowserVersion()); | |||
| options.setBrowserVersion(""); | |||
There was a problem hiding this comment.
GeckoDriver still rejects an empty browser version. Have you checked if the key is still sent?
There was a problem hiding this comment.
Hi @titusfortner , @diemol ,
Looking into the implementation of other bindings, it appears that we should nullify the browser version once we have determined the driver path right?
If yes below should work!
// Once driverPath is available, set browserVersion to null
if (output.result.driver_path) {
options.setBrowserVersion(null);
}
harsha509
added a commit
that referenced
this pull request
Aug 30, 2023
|
Updated the above with commit 1c036ab! closing this PR as suggested by @titusfortner ! |
|
Thanks @harsha509 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS fix equivalent to #12639