[dotnet] Simplfy to only target .NET Standard 2.0 #12608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than targeting multiple individual target framework versions, simplify the project targeting to only target .NET Standard 2.0. Doins so, the resulting assemblies will be usable by projects targeting any of the following versions: * .NET Framework: 4.6.1, 4.6.2, 4.7, 4.7.1, 4.7.2, 4.8, 4.8.1 * .NET Core: 2.0, 2.1, 2.2, 3.0, 3.1 * .NET versions: 5.0, 6.0, 7.0 Additionally, they will be usable from the Mono and Xamarin frameworks. This will simplify the build process and maintenance going forward, and will allow the project to greatly reduce the complexity of the Bazel builds. As a note, this does remove support for .NET 4.5.x, the last version of which (4.5.2) was released in 2014, and reached end-of-life in April 2022.
|
So this effectively removes users of net45 I'm a little delete happy these days, so I'm not going to complain, just wanted to verify. Also, I had someone I trust say:
Is this something we should include as well? Regardless, thank you! This will make building things much easier at least 😂 |
|
This PR makes everybody's live so much easier. Two hands up for being it merged. |
CandorContent
pushed a commit
to CandorContent/selenium
that referenced
this pull request
Aug 25, 2023
* [dotnet] Simplfy to only target .NET Standard 2.0 Rather than targeting multiple individual target framework versions, simplify the project targeting to only target .NET Standard 2.0. Doins so, the resulting assemblies will be usable by projects targeting any of the following versions: * .NET Framework: 4.6.1, 4.6.2, 4.7, 4.7.1, 4.7.2, 4.8, 4.8.1 * .NET Core: 2.0, 2.1, 2.2, 3.0, 3.1 * .NET versions: 5.0, 6.0, 7.0 Additionally, they will be usable from the Mono and Xamarin frameworks. This will simplify the build process and maintenance going forward, and will allow the project to greatly reduce the complexity of the Bazel builds. As a note, this does remove support for .NET 4.5.x, the last version of which (4.5.2) was released in 2014, and reached end-of-life in April 2022. * Add forgotten change to csproj file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplifies the .NET bindings to produce assembly artifacts only targeting .NET Standard 2.0, instead of multi-targeting many different versions of the .NET Frameworks.
Motivation and Context
Rather than targeting multiple individual target framework versions, simplify the project targeting to only target .NET Standard 2.0. Doins so, the resulting assemblies will be usable by projects targeting any of the following versions:
Additionally, they will be usable from the Mono and Xamarin frameworks.
This will simplify the build process and maintenance going forward, and will allow the project to greatly reduce the complexity of the Bazel builds.
As a note, this does remove support for .NET 4.5.x, the last version of which (4.5.2) was released in 2014, and reached end-of-life in April 2022.
Types of changes
Checklist