Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] options do not belong in the service class #12534

Merged
merged 2 commits into from
Aug 27, 2023
Merged

Conversation

titusfortner
Copy link
Member

@titusfortner titusfortner commented Aug 10, 2023

Description

Follow Java approach and use Driver Finder in Driver constructor and not in the Service constructor.

Motivation and Context

If a user creates the service instance independently it will use DriverFinder for the default options instead of specified options. Generally not an issue since users have no reason to create a Service class in .NET if they aren't going to specify the location of the driver. But users need to be able to toggle things like logging without having options. and let DriverFinder still set location based on actual options.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (ca32031) 57.26% compared to head (ba14236) 57.26%.
Report is 4 commits behind head on trunk.

❗ Current head ba14236 differs from pull request most recent head ff10b61. Consider uploading reports for the commit ff10b61 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12534   +/-   ##
=======================================
  Coverage   57.26%   57.26%           
=======================================
  Files          86       86           
  Lines        5335     5335           
  Branches      198      198           
=======================================
  Hits         3055     3055           
  Misses       2082     2082           
  Partials      198      198           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@titusfortner titusfortner force-pushed the net_df branch 3 times, most recently from 3778d9d to 2ec4ab5 Compare August 14, 2023 17:43
@titusfortner titusfortner marked this pull request as ready for review August 14, 2023 18:24
@titusfortner
Copy link
Member Author

@nvborisenko any .NET conventions to fix in my code?

I kind of want to make all Driver location constructors in Driver classes obsolete since Selenium Manager should handle everything now (and there's the service class if it does not).

@titusfortner titusfortner added this to the 4.12 milestone Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants