Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop py37 support #12400

Merged
merged 13 commits into from
Aug 28, 2023
Merged

Drop py37 support #12400

merged 13 commits into from
Aug 28, 2023

Conversation

symonk
Copy link
Member

@symonk symonk commented Jul 22, 2023

Dropping support for python3.7. This encompasses:

  • New python3.8+ syntax in places
  • Dropping 3.7 support in infrastructure code
  • Updating docs for any 3.7 references

closes #12399

@symonk symonk marked this pull request as ready for review July 22, 2023 16:03
@symonk
Copy link
Member Author

symonk commented Jul 22, 2023

not 100% the best approach to rolling this out, don't want to shock users using 3.7 without ample notice. But this is a start on the changes required

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2023

Codecov Report

Patch coverage: 93.10% and no project coverage change.

Comparison is base (09674ae) 57.01% compared to head (8844e9d) 57.02%.

❗ Current head 8844e9d differs from pull request most recent head a9ec7a9. Consider uploading reports for the commit a9ec7a9 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12400   +/-   ##
=======================================
  Coverage   57.01%   57.02%           
=======================================
  Files          86       86           
  Lines        5335     5322   -13     
  Branches      198      192    -6     
=======================================
- Hits         3042     3035    -7     
  Misses       2095     2095           
+ Partials      198      192    -6     
Files Changed Coverage Δ
py/selenium/common/exceptions.py 100.00% <ø> (ø)
py/selenium/types.py 75.00% <ø> (ø)
py/selenium/webdriver/chromium/options.py 77.01% <ø> (ø)
py/selenium/webdriver/chromium/webdriver.py 46.15% <ø> (ø)
py/selenium/webdriver/common/alert.py 53.84% <ø> (ø)
py/selenium/webdriver/common/by.py 100.00% <ø> (ø)
.../selenium/webdriver/common/desired_capabilities.py 100.00% <ø> (ø)
...lenium/webdriver/common/html5/application_cache.py 58.82% <ø> (ø)
py/selenium/webdriver/common/keys.py 100.00% <ø> (ø)
py/selenium/webdriver/common/options.py 34.31% <ø> (ø)
... and 21 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AutomatedTester
Copy link
Member

Do we have a sense of how many folk are on 3.7? I know its either EOL or about to be EOL

@titusfortner
Copy link
Member

Eol was end of June.
My big thing is bazel won't let us test with it, so we don't have an easy way to ensure what we have works with 3.7 anyway.

@AutomatedTester
Copy link
Member

The syntax changes in 3.7->3.8 is partly to blame. I'm ok with dropping it fully since it's past EOL

@AutomatedTester
Copy link
Member

In general this looks good. There are a number of conflicts

@isaulv
Copy link
Contributor

isaulv commented Aug 15, 2023

Most of the changes are style related but it's good to use the more modern type annotations. This should be good to go once conflicts have been addressed.

@isaulv isaulv added the C-py label Aug 15, 2023
@symonk
Copy link
Member Author

symonk commented Aug 21, 2023

Looping back to this now, however i've some conflicts to resolve still, will squash as a single commit when ironed out

@diemol diemol added this to the 4.12 milestone Aug 25, 2023
@diemol diemol merged commit 98d4640 into trunk Aug 28, 2023
@diemol diemol deleted the drop-py37-support branch August 28, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🚀 Feature]: Drop python3.7 support
6 participants