Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js][bidi] add Network module events #12197

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

TamsilAmani
Copy link
Contributor

Description

Add network module events and types

Motivation and Context

Implement network module events and types as described in https://w3c.github.io/webdriver-bidi/#module-network

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@TamsilAmani TamsilAmani requested a review from harsha509 June 13, 2023 15:01
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (4d70bd8) 56.98% compared to head (369cf6e) 56.98%.

❗ Current head 369cf6e differs from pull request most recent head 765747d. Consider uploading reports for the commit 765747d to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12197   +/-   ##
=======================================
  Coverage   56.98%   56.98%           
=======================================
  Files          86       86           
  Lines        5440     5440           
  Branches      226      226           
=======================================
  Hits         3100     3100           
  Misses       2114     2114           
  Partials      226      226           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TamsilAmani TamsilAmani force-pushed the js-bidi-network-events branch from 2b0ad32 to 0b9f8d5 Compare June 15, 2023 08:04
@harsha509 harsha509 merged commit 25dbacb into SeleniumHQ:trunk Jun 15, 2023
@StanislavKharchenko
Copy link

Glad to see this functionality coming soon for JS binding.
Could you please also make some relevant examples for this part?
It will be great to know how to see all pending and/or completed http requests, which application send (as we can see it in the browser "Network" tab).

@TamsilAmani
Copy link
Contributor Author

Hey @StanislavKharchenko. The documentation will be updated soon for the BiDi modules. Meanwhile, I have added tests to this PR also. You can have a look at them to get some idea. Though they aren't written from a user perspective but more from a testing point of view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants