Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] add more shortcuts to webdriver ini file #12194

Merged
merged 4 commits into from
Jun 12, 2023
Merged

[py] add more shortcuts to webdriver ini file #12194

merged 4 commits into from
Jun 12, 2023

Conversation

titusfortner
Copy link
Member

Description

Added missing SafariOptions, and all the browser Service classes to the webdriver aliases.

Motivation and Context

We have required users to move parameters from WebDriver constructor to the Options or Service constructors. We should make it easier to reference the Service constructors. This will also make our documentation pages easier.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 94.23% and project coverage change: +0.41 🎉

Comparison is base (7cfd137) 56.56% compared to head (084c54a) 56.98%.

❗ Current head 084c54a differs from pull request most recent head 1c32ead. Consider uploading reports for the commit 1c32ead to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #12194      +/-   ##
==========================================
+ Coverage   56.56%   56.98%   +0.41%     
==========================================
  Files          86       86              
  Lines        5450     5440      -10     
  Branches      223      226       +3     
==========================================
+ Hits         3083     3100      +17     
+ Misses       2144     2114      -30     
- Partials      223      226       +3     
Impacted Files Coverage Δ
py/selenium/webdriver/remote/errorhandler.py 71.67% <92.50%> (+10.65%) ⬆️
py/selenium/webdriver/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@diemol diemol merged commit 4d70bd8 into trunk Jun 12, 2023
@diemol diemol deleted the py_shorts branch June 12, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants