Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Add Missing W3C Exceptions #12175

Merged
merged 7 commits into from
Jun 8, 2023
Merged

Conversation

LogicOscar
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Add missing w3c errors fix #11817

Description

Adds the following w3c errors to the ErrorCodec class

  • detached shadow root
  • no such shadow root
  • insecure certificate

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Jun 7, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (e55129e) 56.52% compared to head (9a36d23) 56.52%.

❗ Current head 9a36d23 differs from pull request most recent head 3fa3224. Consider uploading reports for the commit 3fa3224 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12175   +/-   ##
=======================================
  Coverage   56.52%   56.52%           
=======================================
  Files          86       86           
  Lines        5454     5454           
  Branches      223      223           
=======================================
  Hits         3083     3083           
  Misses       2148     2148           
  Partials      223      223           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @RevealOscar!

@diemol diemol merged commit da3a82b into SeleniumHQ:trunk Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🚀 Feature]: Add Missing Exceptions
4 participants