Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Drop the prefix created by Bazel #12173

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

joerg1985
Copy link
Member

Description

When Automatic-Module-Name is not set the name of an module will be derived from the jar name.
Bazel will add a prefix to the jar names, this leads to incorrect module names.
This PR add a workaround to drop the prefix of the jar file names.

Motivation and Context

Fixes #11858 and #11556

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you, @joerg1985!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: module not found: processed.jcommander
2 participants