Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rb] allow users to direct driver process output #11964

Merged
merged 1 commit into from
Apr 28, 2023
Merged

[rb] allow users to direct driver process output #11964

merged 1 commit into from
Apr 28, 2023

Conversation

titusfortner
Copy link
Member

Description

Allow users to specify where driver log output goes

Motivation and Context

Currently output is discarded unless the logger level is set to :debug, then all the driver logs are included in the all the Selenium logs

Examples:

Selenium::WebDriver::Service.chrome(log: '/path/to/chromedriver.log')
Selenium::WebDriver::Service.chrome(log: :stdout)
Selenium::WebDriver::Service.chrome(log: :stderr, args: ['--verbose'])

@titusfortner titusfortner requested a review from p0deje April 27, 2023 21:21
@titusfortner titusfortner merged commit da2e767 into trunk Apr 28, 2023
@titusfortner titusfortner deleted the rb_service_log branch April 28, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0deje p0deje p0deje approved these changes

Assignees
No one assigned
Labels
C-rb
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@titusfortner @p0deje