-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rust] Selenium Manager processes PATH #11597
Conversation
Excellent, this is going to make a big difference for users. Right now in the bindings we are skipping calling the selenium manager if users pass in the location of the driver, set it with system property (Java) or on class variable (Ruby), or if the bindings find it on PATH. So with current bindings implementation, this feature won't be used. Ideally the bindings will be able to offload finding the driver on PATH to the manager entirely. We need to be cautious because this would transition the manager to an "opt-out" solution instead of "opt-in." The main feature we need to implement before we can make this transition is #11599. Though, we may want to avoid making this transition until #11357 even. Note: none of this conversation prevents merging this code, just commenting that we have to more carefully think through how/when we implement it in bindings. |
Description
With this PR, Selenium process the
PATH
, i.e., it tries to find the required driver (e.g., chromedriver 109) in the set of local directories where executable programs are located. If the driver is found but is not compatible, it shows aWARN
trace (which can be captured by the bindings using the JSON output format). If found and compatible, it uses it. Here a couple of examples:PATH
in a computer with Chrome 109):Motivation and Context
This PR implements #11356 (and #11373).
Types of changes
Checklist