Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js] Add script pinning #11584

Merged
merged 7 commits into from
Feb 8, 2023
Merged

[js] Add script pinning #11584

merged 7 commits into from
Feb 8, 2023

Conversation

pujagani
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Add script pinning to JS binding

Motivation and Context

All other language bindings allow script pinning. The changes will help achieve feature parity among all languages. Currently, the underlying implementation uses CDP. In future, the same can use BiDi APIs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pujagani pujagani added C-nodejs C-devtools BiDi or Chrome DevTools related issues labels Jan 23, 2023
Copy link
Member

@AutomatedTester AutomatedTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it looks good other than the issues mentioned. Please check the tests

@pujagani pujagani merged commit 8cfe8a4 into SeleniumHQ:trunk Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-devtools BiDi or Chrome DevTools related issues C-nodejs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants