Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py]: 🚀 Improve performance #11310

Merged
merged 3 commits into from
Dec 1, 2022
Merged

Conversation

fenilgmehta
Copy link
Contributor

Description

For each call to text_to_be_present_in_element_attribute(...) we are calling driver.find_element and get_attribute(...) twice. This PR reduced both of them to one.

Motivation and Context

Possible performance optimization and remove redundant calls to driver.find_element and get_attribute(...)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Nov 24, 2022

CLA assistant check
All committers have signed the CLA.

@diemol diemol added the C-py label Nov 24, 2022
@titusfortner titusfortner requested a review from symonk November 25, 2022 17:38
@symonk
Copy link
Member

symonk commented Dec 1, 2022

Thanks @fenilgmehta

@symonk symonk changed the title 🚀 Improve performance [py]: 🚀 Improve performance Dec 1, 2022
@titusfortner titusfortner merged commit 409b057 into SeleniumHQ:trunk Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants