Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix GitHub_Actions set-output is deprecated #11265

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 15, 2022

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

GitHub Actions: Deprecating save-state and set-output commands

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands

Motivation and Context

Currently check_workflow_run/check_workflow GitHub Actions are displaying warnings in the Check_bazel_target_prefix job step.

Warning: The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@titusfortner titusfortner merged commit 471e245 into SeleniumHQ:trunk Nov 28, 2022
@titusfortner
Copy link
Member

thanks!

@cclauss cclauss deleted the ci_fix_GitHub_Actions_set-output_is_deprecated branch November 28, 2022 17:33
@titusfortner
Copy link
Member

Hmm, so I think we're missing something.

The script found python changes, but didn't run:
https://github.com/SeleniumHQ/selenium/actions/runs/3568047641/jobs/5996469979#step:5:81

Does this need to change to reference $GITHUB_OUTPUT?
https://github.com/SeleniumHQ/selenium/blob/trunk/.github/workflows/should-workflow-run.yml#L19

@titusfortner
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants