-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] Add ability to decorate child classes of WebDriver
#10737
[java] Add ability to decorate child classes of WebDriver
#10737
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #10737 +/- ##
=======================================
Coverage 50.42% 50.42%
=======================================
Files 84 84
Lines 5475 5475
Branches 278 278
=======================================
Hits 2761 2761
Misses 2436 2436
Partials 278 278 Continue to review full report at Codecov.
|
Thanks for this PR, we will have a look in depth soon, since it is a sizeable change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have gone through the PR in detail. Overall logic seems right on the looks of it and I understand the use-case the changes are trying to accomplish. I am expressing my concern about merging this and further releasing this. I tried importing the changes into an existing project. It is not a breaking change but existing users will see an inspection message that says "Raw use of parameterized class 'WebDriverDecorator"
. So to avoid that, they will need to make a small update to their existing code. I will check with the selenium-tlc members about how we handle introducing such changes. But I think this is a candidate for a major release.
java/src/org/openqa/selenium/support/decorators/WebDriverDecorator.java
Outdated
Show resolved
Hide resolved
java/src/org/openqa/selenium/support/decorators/WebDriverDecorator.java
Outdated
Show resolved
Hide resolved
java/test/org/openqa/selenium/support/decorators/DecoratedAlertTest.java
Show resolved
Hide resolved
81e80f3
to
0359571
Compare
0359571
to
fa15dd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valfirst Thank you for your contribution! Appreciate it.
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @valfirst!
@diemol @pujagani org.seleniumhq.selenium :4.3.0 |
4.4.0, should be released first week of August. |
Description
The changes enable decoration of custom
WebDriver
implementations.Motivation and Context
Relates appium/java-client#1694
Types of changes
Checklist