-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] Convert RemoteWebElement::getLocation and ::getSize from JWP Standard to W3C Standard #10700
Conversation
…tandard to W3C Standard Fixes SeleniumHQ#10698 as part of SeleniumHQ#10374
Codecov Report
@@ Coverage Diff @@
## trunk #10700 +/- ##
=======================================
Coverage 46.64% 46.64%
=======================================
Files 86 86
Lines 5855 5855
Branches 278 278
=======================================
Hits 2731 2731
Misses 2846 2846
Partials 278 278 Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @BJap!
@diemol For sure and thanks! I waited a bit and didn't see anything pop up for me to see to fix, or a means to import and run tests documented but thanks for catching that as well. I think also as part of #10374 there's constants related to this PR's old commands that could be removed, maybe |
…tandard to W3C Standard (SeleniumHQ#10700) * [Java] Convert RemoteWebElement::getLocation and ::getSize from JWP Standard to W3C Standard Fixes SeleniumHQ#10698 as part of SeleniumHQ#10374 * [java] Fixing RemoteWebElementTest unit tests Co-authored-by: Diego Molina <[email protected]> Co-authored-by: Diego Molina <[email protected]> [skip ci]
Fixes #10698 as part of #10374
This switches two commands that were left over from JWP (which is no longer supported) to use a W3C command instead and achieve the same result.
Description
GET_ELEMENT_LOCATION
andGET_ELEMENT_SIZE
have been changed toGET_ELEMENT_RECT
inside the respectivegetLocation
andgetSize
functions ofRemoteWebElement
Motivation and Context
Anyone running tests in W3C mode will not be able to use these functions as they will throw an exception for trying to use invalid commands.
Types of changes
Checklist