Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include link to license for net.jcip.annotations #9689

Closed
shs96c opened this issue Jul 28, 2021 · 2 comments · Fixed by #9884
Closed

Include link to license for net.jcip.annotations #9689

shs96c opened this issue Jul 28, 2021 · 2 comments · Fixed by #9884
Labels
C-build Build related issues (bazel and CI) C-java
Milestone

Comments

@shs96c
Copy link
Member

shs96c commented Jul 28, 2021

🐛 Bug Report

net.jcip.annotations are licensed under CC BY 2.5, and we use those transitively in the Selenium source. Because of this, they are packaged in the standalone jar. We should include a copy of the license in the jar.

To Reproduce

Unzip and look

Expected behavior

CC BY 2.5 license to be present

Test script or set of commands reproducing this issue

N/A

Environment

OS: N/A
Browser: N/A
Browser version: N/A
Browser Driver version: N/A
Language Bindings version: 3.141.59 and 4.x
Selenium Grid version (if applicable): N/A

@ghost ghost added the needs-triaging label Jul 28, 2021
@shs96c shs96c added C-build Build related issues (bazel and CI) C-java and removed needs-triaging labels Jul 28, 2021
@shs96c shs96c added this to the 4.0 milestone Jul 28, 2021
@shs96c
Copy link
Member Author

shs96c commented Oct 4, 2021

I've been looking for the license itself, and I'm not sure what it actually is. We may be better off flipping to https://github.com/stephenc/jcip-annotations which is Apache 2 licensed.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2021
elgatov pushed a commit to elgatov/selenium that referenced this issue Jun 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-build Build related issues (bazel and CI) C-java
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant