Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: Support for Chromium #12511

Closed
bonigarcia opened this issue Aug 7, 2023 · 4 comments · Fixed by #12890
Closed

[🚀 Feature]: Support for Chromium #12511

bonigarcia opened this issue Aug 7, 2023 · 4 comments · Fixed by #12890
Labels
Milestone

Comments

@bonigarcia
Copy link
Member

Feature and motivation

Modify the existing logic of the Chrome manager (./selenium-manager --browser chrome) to check Chromium (e.g., checking /usr/bin/chromium etc.) when Chrome is unavailable.

Usage example

./selenium-manager --browser chrome

... should return /usr/bin/chromium as result.browser_path if Chrome is not available but Chromium it is.

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

@bonigarcia, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@titusfortner
Copy link
Member

Yeah I think this should be a higher priority because it represents a breaking change from previous behavior.

Ideally, ideally, selenium manager should look for the browser the exact same way that the driver does (in the same order). Not doing so means there are weird non-backwards compatible issues.

@bonigarcia
Copy link
Member Author

I have just sent a PR about Edge management. This one (support for Chromium) will be next.

@bonigarcia bonigarcia moved this from Medium to In Progress in Selenium Manager Oct 2, 2023
@titusfortner titusfortner added this to the 4.14 milestone Oct 6, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Selenium Manager Oct 7, 2023
titusfortner added a commit that referenced this issue Oct 7, 2023
[rust] Detect chromium browser in path (#12511)

Co-authored-by: Titus Fortner <[email protected]>
aguspe pushed a commit to aguspe/selenium that referenced this issue Oct 22, 2023
[rust] Detect chromium browser in path (SeleniumHQ#12511)

Co-authored-by: Titus Fortner <[email protected]>
Copy link

github-actions bot commented Dec 3, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants