-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐛 Bug]: Builder.forBrowser(Browser.INTERNET_EXPLORER) not use selenium-manager #11579
Comments
@cbl980226, thank you for creating this issue. We will troubleshoot it as soon as we can. Info for maintainersTriage this issue by using labels.
If information is missing, add a helpful comment and then
If the issue is a question, add the
If the issue is valid but there is no time to troubleshoot it, consider adding the
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
add the applicable
After troubleshooting the issue, please add the Thank you! |
Is this still happening with 4.8.0? |
Yes, I tried it with 4.8.0 version using the example above , it still happens. driverLocation(Browser.INTERNET_EXPLORER) not allowed https://github.com/SeleniumHQ/selenium/blob/trunk/javascript/node/selenium-webdriver/ie.js#L409 if (!exe) {
console.log(
`The ${IEDRIVER_EXE} executable could not be found on the current PATH, trying Selenium Manager`
)
try {
exe = driverLocation(Browser.INTERNET_EXPLORER)
} catch (err) {
console.log(`Unable to obtain driver using Selenium Manager: ${err}`)
}
} /**
* currently supported browsers for selenium-manager
* @type {string[]}
*/
const Browser = ['chrome', 'firefox', 'edge']
function driverLocation(browser) {
if (!Browser.includes(browser.toLocaleString())) {
throw new Error(
`Unable to locate driver associated with browser name: ${browser}`
)
}
} |
Are you behind a proxy? |
Yes I use the clash proxy |
OK, this is not supported yet. This PR implements it #11575, and we should be able to release in a couple of weeks. |
Sorry, I think maybe not proxy problem. selenium-manager.exe is work for me with proxy. I created a repository => https://github.com/cbl980226/selenium-manager-test I only change driverLocation: |
@bonigarcia could you please help us to check this? |
I think the Selenium JavaScript binding should support IExplorer as well, since Selenium Manager already does. If I am not wrong, in this line: ... it seems that the JavaScript binding does not supports IExplorer yet. |
Good point. Thanks @bonigarcia! @harsha509, is this a matter of adding |
For next version of Selenium, we are hopefully moving to parsing the options instance for browser name and browser version and not using the driver name. |
Looks like a diff issue, if IEDriver not found, JS binding send Fixed with above commit. tested in windows machine! |
Also, added iexplorer into array! Thank you @diego, @titusfortner ! |
What happened?
new Builder().forBrowser(Browser.INTERNET_EXPLORER).build()
not trying Selenium Manager
(seleniumManager.driverLocation)[https://github.com/SeleniumHQ/selenium/blob/634d19acf1274276f40533f4a1243adf2d1be8fb/javascript/node/selenium-webdriver/common/seleniumManager.js#L66] can't get ie driver location
How can we reproduce the issue?
mkdir tests cd tests npm init -y npm add -D selenium-webdriver touch webdriver.test.js node webdriver.test.js
webdriver.test.js
Relevant log output
Operating System
Windows 10
Selenium version
Node [email protected]
What are the browser(s) and version(s) where you see this issue?
None
What are the browser driver(s) and version(s) where you see this issue?
None
Are you using Selenium Grid?
No response
The text was updated successfully, but these errors were encountered: