-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ignoring configurations that does not match current platform. Also, a…
…pparently, node does not read configuration from json resource, it is defined in the code.
- Loading branch information
Showing
1 changed file
with
21 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcb4792
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@barancev The reason for this is JCommander will not invoke
new GridNodeConfiguration()
when it determines the default value. Thus, the expectation (which is a comment in the class file) is to keep the default JSON in sync with the coded defaults -- in case someone callsGridNodeConfiguration foo = GridNodeConfiguration.loadFromJson(DEFAULT_NODE_CONFIG_FILE)
or equivalent for the other config classes. Also FYI - the Test classes should assert thatnew GridNodeConfiguration()
sets the same defaults asGridNodeConfiguration.loadFromJson(DEFAULT_NODE_CONFIG_FILE)
dcb4792
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see any reason why DefaultDesiredCapabilitiesBuilder cannot read capabilities from default JSON...