[rb] manage bidi instance on the bridge not the driver (#14071)

* [rb] manage bidi instance on the bridge not the driver * restore null safety checks
SeleniumHQ · Jun 4, 2024 · cab1dd1 · cab1dd1
1 parent 53ed43c
commit cab1dd1
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 10 deletions.
diff --git a/rb/lib/selenium/webdriver/common/driver.rb b/rb/lib/selenium/webdriver/common/driver.rb
@@ -70,10 +70,9 @@ def for(browser, opts = {})
 
       def initialize(bridge: nil, listener: nil, **opts)
         @devtools = nil
-        @bidi = nil
         bridge ||= create_bridge(**opts)
-        add_extensions(bridge.browser)
         @bridge = listener ? Support::EventFiringBridge.new(bridge, listener) : bridge
+        add_extensions(@bridge.browser)
       end
 
       def inspect
@@ -174,18 +173,14 @@ def quit
       ensure
         @service_manager&.stop
         @devtools&.close
-        @bidi&.close
       end
 
       #
       # Close the current window, or the browser if no windows are left.
       #
 
       def close
-        # If no top-level browsing contexts are open after calling close,
-        # it indicates that the WebDriver session is closed.
-        # If the WebDriver session is closed, the BiDi session also needs to be closed.
-        bridge.close.tap { |handles| @bidi&.close if handles&.empty? }
+        bridge&.close
       end
 
       #

diff --git a/rb/lib/selenium/webdriver/common/driver_extensions/has_bidi.rb b/rb/lib/selenium/webdriver/common/driver_extensions/has_bidi.rb
@@ -28,7 +28,7 @@ module HasBiDi
         #
 
         def bidi
-          @bidi ||= Selenium::WebDriver::BiDi.new(url: capabilities[:web_socket_url])
+          @bridge.bidi
         end
       end # HasBiDi
     end # DriverExtensions

diff --git a/rb/lib/selenium/webdriver/remote/bridge.rb b/rb/lib/selenium/webdriver/remote/bridge.rb
@@ -213,10 +213,12 @@ def quit
           http.close
         rescue *QUIT_ERRORS
           nil
+        ensure
+          @bidi&.close
         end
 
         def close
-          execute :close_window
+          execute(:close_window).tap { |handles| @bidi&.close if handles.empty? }
         end
 
         def refresh
@@ -602,6 +604,13 @@ def user_verified(verified, authenticator_id)
           execute :set_user_verified, {authenticatorId: authenticator_id}, {isUserVerified: verified}
         end
 
+        def bidi
+          msg = 'this operation requires enabling BiDi by setting #web_socket_url to true in options class'
+          raise(WebDriver::Error::WebDriverError, msg) unless capabilities.web_socket_url
+
+          @bidi ||= Selenium::WebDriver::BiDi.new(url: capabilities[:web_socket_url])
+        end
+
         def command_list
           COMMANDS
         end

diff --git a/rb/sig/lib/selenium/webdriver/common/driver.rbs b/rb/sig/lib/selenium/webdriver/common/driver.rbs
@@ -5,7 +5,6 @@ module Selenium
 
       include TakesScreenshot
 
-      @bidi: untyped
       @devtools: untyped
       @navigate: untyped
 

diff --git a/rb/sig/lib/selenium/webdriver/remote/bridge.rbs b/rb/sig/lib/selenium/webdriver/remote/bridge.rbs
@@ -5,6 +5,7 @@ module Selenium
         include _CommandList
         include _Features
 
+        @bidi: WebDriver::BiDi
         @http: untyped
 
         @file_detector: untyped