[java] Fix SpotBugs findings in ChromiumDriver and PortProber (#1…

…4589) Co-authored-by: Puja Jagani <[email protected]>
SeleniumHQ · Oct 14, 2024 · c7daf73 · c7daf73
1 parent e9da405
commit c7daf73
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/java/src/org/openqa/selenium/chromium/ChromiumDriver.java b/java/src/org/openqa/selenium/chromium/ChromiumDriver.java
@@ -212,7 +212,8 @@ public ScriptKey pin(String script) {
     // Create the actual script we're going to use.
     String scriptToUse =
         String.format(
-            "window.seleniumPinnedScript%s = function(){%s}", Math.abs(script.hashCode()), script);
+            "window.seleniumPinnedScript%s = function(){%s}",
+            Math.abs((long) script.hashCode()), script);
 
     DevTools devTools = getDevTools();
     devTools.createSessionIfThereIsNotOne();

diff --git a/java/src/org/openqa/selenium/net/PortProber.java b/java/src/org/openqa/selenium/net/PortProber.java
@@ -119,7 +119,7 @@ private static boolean isFree(String bindHost, int port) {
       socket.setReuseAddress(true);
       socket.bind(new InetSocketAddress(bindHost, port));
       return true;
-    } catch (Exception e) {
+    } catch (IOException | RuntimeException e) {
       return false;
     }
   }