update specs so navigation completes before adding handlers

SeleniumHQ · Jun 4, 2024 · aeb7b85 · aeb7b85
1 parent 5b2c1d4
commit aeb7b85
Showing 1 changed file with 12 additions and 8 deletions.
diff --git a/rb/spec/integration/selenium/webdriver/bidi/script_spec.rb b/rb/spec/integration/selenium/webdriver/bidi/script_spec.rb
@@ -34,10 +34,10 @@ module WebDriver
       end
 
       it 'logs console messages' do
-        log_entries = []
+        driver.navigate.to url_for('bidi/logEntryAdded.html')
 
+        log_entries = []
         driver.script.add_console_message_handler { |log| log_entries << log }
-        driver.navigate.to url_for('bidi/logEntryAdded.html')
 
         driver.find_element(id: 'jsException').click
         driver.find_element(id: 'consoleLog').click
@@ -53,41 +53,45 @@ module WebDriver
       end
 
       it 'logs multiple console messages' do
-        log_entries = []
+        driver.navigate.to url_for('bidi/logEntryAdded.html')
 
+        log_entries = []
         driver.script.add_console_message_handler { |log| log_entries << log }
         driver.script.add_console_message_handler { |log| log_entries << log }
-        driver.navigate.to url_for('bidi/logEntryAdded.html')
 
         driver.find_element(id: 'jsException').click
         driver.find_element(id: 'consoleLog').click
+        driver.find_element(id: 'consoleLog').click
 
         wait.until { log_entries.size > 1 }
         expect(log_entries.size).to eq(2)
       end
 
       it 'logs removes console message handler' do
-        log_entries = []
+        driver.navigate.to url_for('bidi/logEntryAdded.html')
 
+        log_entries = []
         id = driver.script.add_console_message_handler { |log| log_entries << log }
         driver.script.add_console_message_handler { |log| log_entries << log }
-        driver.navigate.to url_for('bidi/logEntryAdded.html')
+
         driver.find_element(id: 'consoleLog').click
 
         wait.until { log_entries.size > 1 }
 
         driver.script.remove_console_message_handler(id)
+
         driver.find_element(id: 'consoleLog').click
 
         wait.until { log_entries.size > 2 }
         expect(log_entries.size).to eq(3)
       end
 
       it 'logs javascript errors' do
-        log_entries = []
+        driver.navigate.to url_for('bidi/logEntryAdded.html')
 
+        log_entries = []
         driver.script.add_javascript_error_handler { |log| log_entries << log }
-        driver.navigate.to url_for('bidi/logEntryAdded.html')
+
         driver.find_element(id: 'consoleLog').click
         driver.find_element(id: 'jsException').click