[py] DeprecationWarning raised in default webdriver init (#14690)

Signed-off-by: Viet Nguyen Duc <[email protected]>
SeleniumHQ · Oct 31, 2024 · 961db5e · 961db5e
1 parent b9b384a
commit 961db5e
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 10 deletions.
diff --git a/py/selenium/webdriver/chromium/remote_connection.py b/py/selenium/webdriver/chromium/remote_connection.py
@@ -30,9 +30,8 @@ def __init__(
         ignore_proxy: Optional[bool] = False,
         client_config: Optional[ClientConfig] = None,
     ) -> None:
+        client_config = client_config or ClientConfig(remote_server_addr=remote_server_addr, keep_alive=keep_alive)
         super().__init__(
-            remote_server_addr=remote_server_addr,
-            keep_alive=keep_alive,
             ignore_proxy=ignore_proxy,
             client_config=client_config,
         )

diff --git a/py/selenium/webdriver/firefox/remote_connection.py b/py/selenium/webdriver/firefox/remote_connection.py
@@ -32,9 +32,8 @@ def __init__(
         ignore_proxy: Optional[bool] = False,
         client_config: Optional[ClientConfig] = None,
     ) -> None:
+        client_config = client_config or ClientConfig(remote_server_addr=remote_server_addr, keep_alive=keep_alive)
         super().__init__(
-            remote_server_addr=remote_server_addr,
-            keep_alive=keep_alive,
             ignore_proxy=ignore_proxy,
             client_config=client_config,
         )

diff --git a/py/selenium/webdriver/ie/webdriver.py b/py/selenium/webdriver/ie/webdriver.py
@@ -16,6 +16,7 @@
 # under the License.
 
 from selenium.webdriver.common.driver_finder import DriverFinder
+from selenium.webdriver.remote.client_config import ClientConfig
 from selenium.webdriver.remote.remote_connection import RemoteConnection
 from selenium.webdriver.remote.webdriver import WebDriver as RemoteWebDriver
 
@@ -49,10 +50,10 @@ def __init__(
         self.service.path = self.service.env_path() or DriverFinder(self.service, options).get_driver_path()
         self.service.start()
 
+        client_config = ClientConfig(remote_server_addr=self.service.service_url, keep_alive=keep_alive)
         executor = RemoteConnection(
-            remote_server_addr=self.service.service_url,
-            keep_alive=keep_alive,
             ignore_proxy=options._ignore_local_proxy,
+            client_config=client_config,
         )
 
         try:

diff --git a/py/selenium/webdriver/safari/remote_connection.py b/py/selenium/webdriver/safari/remote_connection.py
@@ -32,9 +32,8 @@ def __init__(
         ignore_proxy: Optional[bool] = False,
         client_config: Optional[ClientConfig] = None,
     ) -> None:
+        client_config = client_config or ClientConfig(remote_server_addr=remote_server_addr, keep_alive=keep_alive)
         super().__init__(
-            remote_server_addr=remote_server_addr,
-            keep_alive=keep_alive,
             ignore_proxy=ignore_proxy,
             client_config=client_config,
         )

diff --git a/py/selenium/webdriver/safari/webdriver.py b/py/selenium/webdriver/safari/webdriver.py
@@ -16,6 +16,7 @@
 # under the License.
 
 from selenium.common.exceptions import WebDriverException
+from selenium.webdriver.remote.client_config import ClientConfig
 from selenium.webdriver.remote.webdriver import WebDriver as RemoteWebDriver
 
 from ..common.driver_finder import DriverFinder
@@ -50,10 +51,10 @@ def __init__(
         if not self.service.reuse_service:
             self.service.start()
 
+        client_config = ClientConfig(remote_server_addr=self.service.service_url, keep_alive=keep_alive)
         executor = SafariRemoteConnection(
-            remote_server_addr=self.service.service_url,
-            keep_alive=keep_alive,
             ignore_proxy=options._ignore_local_proxy,
+            client_config=client_config,
         )
 
         try: