Merge pull request #778 from anto-ac/issue-772-cannot-open-display

Find free xvfb display instead of hardcoded 99 using the -a option
SeleniumHQ · Aug 30, 2018 · 96ffe69 · 96ffe69
2 parents f0c5ad4 + 8fdb929
commit 96ffe69
Show file tree

Hide file tree

Showing 9 changed files with 16 additions and 104 deletions.
diff --git a/Makefile b/Makefile
@@ -211,8 +211,7 @@ release: tag_major_minor
 	docker push $(NAME)/standalone-chrome-debug:$(MAJOR_MINOR_PATCH)
 	docker push $(NAME)/standalone-firefox-debug:$(MAJOR_MINOR_PATCH)
 
-test: test_shell_functions \
- test_chrome \
+test: test_chrome \
  test_firefox \
  test_chrome_debug \
  test_firefox_debug \
@@ -222,9 +221,6 @@ test: test_shell_functions \
  test_firefox_standalone_debug
 
 
-test_shell_functions:
-	./tests/test-shell-functions.sh
-
 test_chrome:
 	VERSION=$(VERSION) NAMESPACE=$(NAMESPACE) ./tests/bootstrap.sh NodeChrome
 

diff --git a/NodeBase/Dockerfile.txt b/NodeBase/Dockerfile.txt
@@ -72,17 +72,14 @@ USER seluser
 #==============================
 # Scripts to run Selenium Node
 #==============================
-COPY entry_point.sh \
-  functions.sh \
-    /opt/bin/
+COPY entry_point.sh  /opt/bin/
 
 #============================
 # Some configuration options
 #============================
 ENV SCREEN_WIDTH 1360
 ENV SCREEN_HEIGHT 1020
 ENV SCREEN_DEPTH 24
-ENV DISPLAY :99.0
 
 #========================
 # Selenium Configuration

diff --git a/NodeBase/entry_point.sh b/NodeBase/entry_point.sh
@@ -1,6 +1,5 @@
 #!/bin/bash
 
-source /opt/bin/functions.sh
 /opt/bin/generate_config > /opt/selenium/config.json
 
 export GEOMETRY="$SCREEN_WIDTH""x""$SCREEN_HEIGHT""x""$SCREEN_DEPTH"
@@ -42,11 +41,9 @@ if [ ! -z "$SE_OPTS" ]; then
   echo "appending selenium options: ${SE_OPTS}"
 fi
 
-SERVERNUM=$(get_server_num)
-
 rm -f /tmp/.X*lock
 
-xvfb-run -n $SERVERNUM --server-args="-screen 0 $GEOMETRY -ac +extension RANDR" \
+xvfb-run -a --server-args="-screen 0 $GEOMETRY -ac +extension RANDR" \
   java ${JAVA_OPTS} -jar /opt/selenium/selenium-server-standalone.jar \
     -role node \
     -hub http://$HUB_PORT_4444_TCP_ADDR:$HUB_PORT_4444_TCP_PORT/grid/register \

diff --git a/NodeBase/functions.sh b/NodeBase/functions.sh
diff --git a/NodeBase/test-functions.sh b/NodeBase/test-functions.sh
diff --git a/NodeDebug/entry_point.sh b/NodeDebug/entry_point.sh
@@ -2,7 +2,6 @@
 #
 # IMPORTANT: Change this file only in directory NodeDebug!
 
-source /opt/bin/functions.sh
 /opt/bin/generate_config > /opt/selenium/config.json
 
 export GEOMETRY="$SCREEN_WIDTH""x""$SCREEN_HEIGHT""x""$SCREEN_DEPTH"
@@ -51,12 +50,9 @@ if [ ! -z "$SE_OPTS" ]; then
   echo "appending selenium options: ${SE_OPTS}"
 fi
 
-SERVERNUM=$(get_server_num)
-
 rm -f /tmp/.X*lock
 
-DISPLAY=$DISPLAY \
-  xvfb-run -n $SERVERNUM --server-args="-screen 0 $GEOMETRY -ac +extension RANDR" \
+xvfb-run -a --server-args="-screen 0 $GEOMETRY -ac +extension RANDR" \
   java ${JAVA_OPTS} -jar /opt/selenium/selenium-server-standalone.jar \
     -role node \
     -hub http://$HUB_PORT_4444_TCP_ADDR:$HUB_PORT_4444_TCP_PORT/grid/register \
@@ -68,6 +64,11 @@ NODE_PID=$!
 trap shutdown SIGTERM SIGINT
 for i in $(seq 1 10)
 do
+  DISPLAY=$(xvfb-run printenv DISPLAY)
+  if [ -z "$DISPLAY" ]; then
+    echo "\$DISPLAY env variable is empty"
+    break
+  fi
   xdpyinfo -display $DISPLAY >/dev/null 2>&1
   if [ $? -eq 0 ]; then
     break

diff --git a/Standalone/entry_point.sh b/Standalone/entry_point.sh
@@ -2,8 +2,6 @@
 #
 # IMPORTANT: Change this file only in directory Standalone!
 
-source /opt/bin/functions.sh
-
 export GEOMETRY="$SCREEN_WIDTH""x""$SCREEN_HEIGHT""x""$SCREEN_DEPTH"
 
 function shutdown {
@@ -15,11 +13,9 @@ if [ ! -z "$SE_OPTS" ]; then
   echo "appending selenium options: ${SE_OPTS}"
 fi
 
-SERVERNUM=$(get_server_num)
-
 rm -f /tmp/.X*lock
 
-xvfb-run -n $SERVERNUM --server-args="-screen 0 $GEOMETRY -ac +extension RANDR" \
+xvfb-run -a --server-args="-screen 0 $GEOMETRY -ac +extension RANDR" \
   java ${JAVA_OPTS} -jar /opt/selenium/selenium-server-standalone.jar \
   ${SE_OPTS} &
 NODE_PID=$!

diff --git a/StandaloneDebug/entry_point.sh b/StandaloneDebug/entry_point.sh
@@ -2,8 +2,6 @@
 #
 # IMPORTANT: Change this file only in directory StandaloneDebug!
 
-source /opt/bin/functions.sh
-
 export GEOMETRY="$SCREEN_WIDTH""x""$SCREEN_HEIGHT""x""$SCREEN_DEPTH"
 
 function shutdown {
@@ -24,17 +22,19 @@ fi
 
 rm -f /tmp/.X*lock
 
-SERVERNUM=$(get_server_num)
-
-DISPLAY=$DISPLAY \
-  xvfb-run -n $SERVERNUM --server-args="-screen 0 $GEOMETRY -ac +extension RANDR" \
+xvfb-run -a --server-args="-screen 0 $GEOMETRY -ac +extension RANDR" \
   java ${JAVA_OPTS} -jar /opt/selenium/selenium-server-standalone.jar \
   ${SE_OPTS} &
 NODE_PID=$!
 
 trap shutdown SIGTERM SIGINT
 for i in $(seq 1 10)
 do
+  DISPLAY=$(xvfb-run printenv DISPLAY)
+  if [ -z "$DISPLAY" ]; then
+    echo "\$DISPLAY env variable is empty"
+    break
+  fi
   xdpyinfo -display $DISPLAY >/dev/null 2>&1
   if [ $? -eq 0 ]; then
     break

diff --git a/tests/test-shell-functions.sh b/tests/test-shell-functions.sh