[New Feature] Support bip45 nonsegwit legacy multisig p2sh #540
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds p2sh nonsegwit legacy multisig support.
The intention is to at least support bip45 (
m/45'
) p2sh multisig, which is the format used by Unchained. There may be some assumptions baked in here that might not fully support all arbitrary p2sh scripts.embit_utils
andpsbt_parser
to support p2sh.Additional tests:
test_embit_utils
test_psbt_parser
.Misc:
test_psbt_parser.py
was using tab indents which have now been changed to spaces in this PR (which is why the otherwise unaltered p2tr test shows up in this diff).To aid testing, here is the p2sh multisig descriptor used in the psbt_parser test:
The descriptor from the test can also be imported into Sparrow for more interactive testing / sanity checking:
-n regtest
Additional resources:
This pull request is categorized as a:
Checklist
pytest
and made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os: