-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build workflow for seedsigner. #392
Conversation
name: Build | ||
|
||
on: | ||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want every push to trigger a build, so I choose to let users manually trigger it. See: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#on
Very interesting concept, I will review closer later. I’ve got no experience with GitHub build actions. |
Hi @newtonick, you can download the compiled image and view the compilation process here. https://github.com/overcat/seedsigner/actions/runs/5273505981 |
@newtonick seems like this PR should be blocked by the reproducible build efforts. Once that path is clear, then we can make sure that the exact same steps are included here. It would be nice to have an automate-able way for people to trigger their own build process and confirm the result. Obv this would be the least-trustworthy verification method (due to all the potentially mysterious automation), but still a good option. |
@overcat do Github Actions charge a fee for the VM time? |
It is free, see https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration#about-billing-for-github-actions
|
Tested and worked well. I'm hoping there is opportunity to iterate and make this action even better. Thanks for the contribution and kick starting this idea automating the build process for easier testing and sha256 hashes. |
I have been busy with other projects recently. If I have free time afterwards, I will follow up on it again. |
This PR enables users to directly build images through GitHub Actions.
It will take about 2 hours without cache, and about 40 minutes with cache.