mpv-git: Update to 20241213 using Github Releases #14574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous Sourceforge mirror has not been receiving recent builds by shinchiro. This commit update the checkver source to use the Github releases API source. All the MPV build are built through Github Actions and automatically released nightly. This is a more direct source than downloading from Sourceforge.
|
/verify edit: (is the process automatic now, or is this still necessary for every PR?) |
|
All changes look good. Wait for review from human collaborators. mpv-git
|
1 similar comment
|
All changes look good. Wait for review from human collaborators. mpv-git
|
|
ok, so a day after I open this, builds start uploading to Sourceforge again. I guess it up for debate whether this change so be made for the sake of being consistent with mpv.io links and as a more direct source, as opposed to the sourceforge mirror. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous Sourceforge mirror has not been receiving recent builds by shinchiro. This PR updates the checkver source to use the Github releases API source. All the MPV builds are done with Github Actions and automatically released nightly. This is a more direct source than downloading from Sourceforge.
The build repository https://github.com/shinchiro/mpv-winbuild-cmake/
The repo is directly linked to on https://mpv.io/installation/ as a source of Windows binaries. They are no-longer linking to Sourceforge.
Further updates could be made to modernize this manifest, e.g. #11123
It is also unclear if the change in #9662 of adding the mpv(-git) install directory to PATH is still necessary in 202[45].
I personally dislike it and prefer not to pollute PATH, but I also don't use the package that caused the original issue in #9662.
I have left that as is for this PR.
It is likely that the
mpv.json(non-git builds) will need to be migrated from Sourceforge as well, however there has yet to be a full MPV release since the current v0.39.0, so we have yet to see where the next version will be released (Github releases or Sourceforge mirror).