winscp: fix download url & autoupdate url #14546
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your changes do not pass checks. winscp
|
|
Looks like the page you are referencing is a download placeholder for a cdn, the actual link from their cdn is "https://cdn.winscp.net/files/WinSCP-6.3.6-Portable.zip?secure=9FweEKieEPd1v28jDRhStA==,1734027149" which may have rotating keys to prevent automatic downloads. Sourceforge is still a viable source for downloading WinSCP and does not seem to be going anywhere. |
|
you're unfortunately right.
the hash code should be the same even when downloading through a cdn. I'm
still trying to find out why it works for me locally but not in the CI
Pipeline.
…On Thu, Dec 12, 2024, 18:16 Jacob Lane Ledbetter ***@***.***> wrote:
Looks like the page you are referencing is a download placeholder for a
cdn, the actual link from their cdn is "
https://cdn.winscp.net/files/WinSCP-6.3.6-Portable.zip?secure=9FweEKieEPd1v28jDRhStA==,1734027149"
which may have rotating keys to prevent automatic downloads. Sourceforge is
still a viable source for downloading WinSCP and does not seem to be going
anywhere.
—
Reply to this email directly, view it on GitHub
<#14546 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABWAWRIB6RLASZXTZLS26BL2FHAIPAVCNFSM6AAAAABTK3SDBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZZGU2DSNZXHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced the Sourceforge URL with the one provided by WinSCP directly.
Relates to #5318, #4418, #827