Demo Numpy v2 #6035
Merged
Demo Numpy v2 #6035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
benchmark_this
5 tasks
trexfeathers
added a commit
to trexfeathers/iris
that referenced
this pull request
Jul 2, 2024
bjlittle
pushed a commit
that referenced
this pull request
Jul 3, 2024
* NEP29 NumPy pin. * Pin back from NumPy v2 (#6035). * PyPI pins.
|
Note to self: |
⏱️ Performance Benchmark Report: 7a969b1Performance shiftsFull benchmark resultsGenerated by GHA run |
Fix doctests.
Closed
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6035 +/- ##
==========================================
+ Coverage 89.82% 89.83% +0.01%
==========================================
Files 88 88
Lines 23185 23211 +26
Branches 4314 4316 +2
==========================================
+ Hits 20825 20852 +27
+ Misses 1628 1627 -1
Partials 732 732 ☔ View full report in Codecov by Sentry. |
|
I propose that the performance changes (e.g. #6035 (comment)) are:
|
|
⏱️ Performance Benchmark Report: 973b37fPerformance shiftsFull benchmark resultsGenerated by GHA run |
⏱️ Performance Benchmark Report: 35046d6Performance shiftsFull benchmark resultsGenerated by GHA run |
⏱️ Performance Benchmark Report: fcf2457Performance shiftsFull benchmark resultsGenerated by GHA run |
HGWright
approved these changes
Oct 24, 2024
|
Thanks @HGWright! |
HGWright
added a commit
to HGWright/iris
that referenced
this pull request
Oct 31, 2024
* upstream/main: (194 commits) Restore latest Whats New files. [pre-commit.ci] pre-commit autoupdate (SciTools#6205) correct major minor in whatsnew (SciTools#6202) What's new updates for v3.11.0rc0 . (SciTools#6201) Update CF standard names table. (SciTools#6200) Specify meta in dask.array.map_blocks (SciTools#5989) added in a vertical rule for surface fields (SciTools#5734) Updated environment lockfiles (SciTools#6197) Reduce duplication in cf.py spanning checks. (SciTools#6196) Fix attribute array comparison (SciTools#6181) Enable factory references to create new dimensions on load. (SciTools#6168) (SciTools#6194) Improve handling of masks in concatenate (SciTools#6187) Demo Numpy v2 (SciTools#6035) Bump scitools/workflows from 2024.10.1 to 2024.10.2 (SciTools#6186) Document use of new_axis to control merge (SciTools#6180) Updated environment lockfiles (SciTools#6184) [pre-commit.ci] pre-commit autoupdate (SciTools#6175) Updated environment lockfiles (SciTools#6183) Update to `cell_method` parsing (SciTools#6083) Bump scitools/workflows from 2024.10.0 to 2024.10.1 (SciTools#6179) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This PR expands on the original demonstration (a82bea0) to make Iris fully NumPy v2 compliant. Notable changes:
Expand for the text from the original demonstration:
We already know that Iris' syntax is NumPy v2 compliant, thanks to Ruff, but that does not prove that the code will all function with NumPy v2.
A vanilla Conda install of Iris does get NumPy v2, but unfortunately our full test environment does not (some of the dependencies must be pinned). So I have forced the issue by manually editing
requirements/locks/py312-linux-64.lock, which does thankfully produce a working environment since none of NumPy's dependencies have changed.The test failures show us what work we need to do for Iris to be compliant with NumPy v2. It seems to mostly be around changes in:
dtypesConsult Iris pull request check list
Add any of the below labels to trigger actions on this PR: