-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eccodes 2v36 #504
Eccodes 2v36 #504
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #504 +/- ##
==========================================
+ Coverage 89.13% 89.16% +0.02%
==========================================
Files 8 8
Lines 2467 2473 +6
Branches 418 420 +2
==========================================
+ Hits 2199 2205 +6
Misses 170 170
Partials 98 98 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pp-mo!
I used this for reference during my review: v2.36.0 release notes
Fixes for a couple of backwards-incompatibilities introduced in eccodes version 2.36
N.B. this also tested OK against 2.35, for which these lines are required.However, it's not clear how old an eccodes this will support, sinceindicatorOfUnitOfTimeRange
is only aliassed on loading -- not in saving, where setting it always+only usesindicatorOfUnitForForecastTime
(the new form).From their release page, v2.33 is when
indicatorOfUnitForForecastTime
was introduced, which we now write on saves.Tested against eccodes v2.33 and v2.32 : confirmed the new code works with 2.33 but not 2.32.
As stated in whatsnew + updated requirements yml files.
N.B. the old name
indicatorOfUnitOfTimeRange
is still used in grib1 loading, because that still requires it(!yuck!)