Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eccodes 2v36 #504

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Eccodes 2v36 #504

merged 4 commits into from
Jul 17, 2024

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Jul 5, 2024

Fixes for a couple of backwards-incompatibilities introduced in eccodes version 2.36

N.B. this also tested OK against 2.35, for which these lines are required.
However, it's not clear how old an eccodes this will support, since indicatorOfUnitOfTimeRange is only aliassed on loading -- not in saving, where setting it always+only uses indicatorOfUnitForForecastTime (the new form).

From their release page, v2.33 is when indicatorOfUnitForForecastTime was introduced, which we now write on saves.
Tested against eccodes v2.33 and v2.32 : confirmed the new code works with 2.33 but not 2.32.
As stated in whatsnew + updated requirements yml files.

N.B. the old name indicatorOfUnitOfTimeRange is still used in grib1 loading, because that still requires it
(!yuck!)

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.16%. Comparing base (6b97a7e) to head (69a8e90).
Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
+ Coverage   89.13%   89.16%   +0.02%     
==========================================
  Files           8        8              
  Lines        2467     2473       +6     
  Branches      418      420       +2     
==========================================
+ Hits         2199     2205       +6     
  Misses        170      170              
  Partials       98       98              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pp-mo!

I used this for reference during my review: v2.36.0 release notes

src/iris_grib/_save_rules.py Show resolved Hide resolved
src/iris_grib/_save_rules.py Show resolved Hide resolved
@trexfeathers trexfeathers merged commit 79a6b05 into SciTools:main Jul 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eccodes>=2.33.0 breaks loading cubes using iris/iris-grib
3 participants