Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add toml to manifest #436

Merged
merged 1 commit into from
Apr 18, 2024
Merged

add toml to manifest #436

merged 1 commit into from
Apr 18, 2024

Conversation

bjlittle
Copy link
Member

This pull-request adds *.toml files to the sdist manifest.

Copy link
Contributor

@HGWright HGWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice spot to fix the failures.

@HGWright HGWright merged commit 71703ae into SciTools:main Apr 18, 2024
9 checks passed
@trexfeathers
Copy link
Contributor

@bjlittle perhaps you can educate me: I would have expected to exclude .toml files, since they won't be required as part of a user install?

I note that Iris excludes .ruff.toml specifically, and makes no mention at all of pyproject.toml, suggesting that maybe some special rules apply there.


Note that following two similar PR's, we now have this:

iris-grib/MANIFEST.in

Lines 13 to 16 in 71703ae

exclude .ruff.toml
include *.md
include *.py
include *.toml

I knew I should have checked main before merging #435!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants