Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to gdt90 load. #223

Merged
merged 3 commits into from
Sep 30, 2020
Merged

Changes to gdt90 load. #223

merged 3 commits into from
Sep 30, 2020

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Sep 24, 2020 •
edited
Loading

Ready to go now. I think.

Closes #222

@trexfeathers trexfeathers marked this pull request as draft September 25, 2020 11:02
@trexfeathers
Copy link
Contributor

Closes #222

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.482% when pulling 7ccdf56 on pp-mo:gdt90_geos into 4b7797f on SciTools:master.

@pp-mo pp-mo marked this pull request as ready for review September 29, 2020 10:28
@pp-mo pp-mo mentioned this pull request Sep 29, 2020
Merged
@trexfeathers trexfeathers self-requested a review September 30, 2020 08:10
@pp-mo pp-mo added this to the v0.16.0 milestone Sep 30, 2020
trexfeathers
trexfeathers approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pp-mo, LGTM!

@trexfeathers trexfeathers merged commit dc3cdca into SciTools:master Sep 30, 2020
@pp-mo pp-mo deleted the gdt90_geos branch November 29, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trexfeathers trexfeathers trexfeathers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.

Correct loading of "space view" grids
3 participants
@pp-mo @trexfeathers @coveralls