MNT: add missing 'needs network' markers #2369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglucas
approved these changes
Apr 12, 2024
QuLogic
pushed a commit
to QuLogic/cartopy
that referenced
this pull request
Sep 22, 2024
MNT: add missing 'needs network' markers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Closes #2368 by applying the provided patch with some tweaks. I think I am responsible for the vast majority of these omissions 🐑
Tested locally by disconnecting my laptop from wifi, clearing out my cartopy data and running with
pytest -n4 -m "not natural_earth and not network"Implications