Use truncated instead of Truncated
#101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The procedure to run it is documented in https://github.com/SciML/DiffEqBenchmarks.jl#contributing . It might be good to re-weave all 3 of those. @Vaibhavdixit02 and I have been discussing the Lorenz one, because Stan fails with those priors by just never finishing, so we are trying to find a good way to document that behavior, like cut it early or something. If you have any ideas go for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed that DiffEqBenchmarks uses the deprecated
Truncatedinstead oftruncatedwhich (potentially) creates optimized truncated distributions and usesTruncatedas fallback. I remember some simple models in Turing being quite slow due to deprecation warnings, so probably better to usetruncatedin the benchmarks.I'm not sure what's the correct procedure for rerunning and regenerating the different output formats?