Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite solutions of DDE problems #310

Merged
merged 2 commits into from
Apr 12, 2018
Merged

Composite solutions of DDE problems #310

merged 2 commits into from
Apr 12, 2018

Conversation

devmotion
Copy link
Member

I started looking into SciML/DelayDiffEq.jl#64 and noticed that currently it is not possible to build ODECompositeSolutions from DDEProblems, i.e. without this PR https://github.com/JuliaDiffEq/DelayDiffEq.jl/blob/master/src/solve.jl#L59-L62 creates just a ODESolution.

Copy link
Member

@ChrisRackauckas ChrisRackauckas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge when tests pass

@coveralls
Copy link

coveralls commented Apr 12, 2018

Coverage Status

Coverage decreased (-0.003%) to 79.636% when pulling 834949b on composite_dde into ef4ca42 on master.

@codecov
Copy link

codecov bot commented Apr 12, 2018

Codecov Report

Merging #310 into master will decrease coverage by 11.22%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #310       +/-   ##
===========================================
- Coverage   79.63%   68.41%   -11.23%     
===========================================
  Files          69       69               
  Lines       23044    23028       -16     
===========================================
- Hits        18352    15754     -2598     
- Misses       4692     7274     +2582
Impacted Files Coverage Δ
src/composite_solution.jl 0% <0%> (-71.43%) ⬇️
src/perform_step/threaded_rk_perform_step.jl 0% <0%> (-100%) ⬇️
src/composite_algs.jl 0% <0%> (-100%) ⬇️
src/dense/high_order_rk_addsteps.jl 2.12% <0%> (-97.88%) ⬇️
src/perform_step/composite_perform_step.jl 4.16% <0%> (-87.5%) ⬇️
src/callbacks.jl 0% <0%> (-86.96%) ⬇️
src/dense/low_order_rk_addsteps.jl 14.11% <0%> (-85.29%) ⬇️
src/dense/stiff_addsteps.jl 4.25% <0%> (-83.52%) ⬇️
src/caches/feagin_caches.jl 23.68% <0%> (-76.32%) ⬇️
src/perform_step/feagin_rk_perform_step.jl 25% <0%> (-75%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef4ca42...834949b. Read the comment docs.

@ChrisRackauckas ChrisRackauckas merged commit 61a639b into master Apr 12, 2018
@ChrisRackauckas ChrisRackauckas deleted the composite_dde branch April 12, 2018 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants