-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for Broyden and Klement #303
Merged
Merged
+482
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/better_init
branch
2 times, most recently
from
December 6, 2023 16:08
b7a1ef8
to
50daa20
Compare
avik-pal
changed the title
True Jacobian Initialization for Broyden and Klement
Improvements for Broyden and Klement
Dec 6, 2023
avik-pal
force-pushed
the
ap/better_init
branch
from
December 7, 2023 01:51
0571034
to
60b408c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #303 +/- ##
==========================================
- Coverage 88.01% 86.08% -1.94%
==========================================
Files 21 21
Lines 1669 1825 +156
==========================================
+ Hits 1469 1571 +102
- Misses 200 254 +54 ☔ View full report in Codecov by Sentry. |
avik-pal
force-pushed
the
ap/better_init
branch
2 times, most recently
from
December 7, 2023 04:16
9b164e2
to
eb26276
Compare
avik-pal
force-pushed
the
ap/better_init
branch
from
December 7, 2023 05:37
5e5d34e
to
7b7bd29
Compare
avik-pal
force-pushed
the
ap/better_init
branch
from
December 7, 2023 05:44
7b7bd29
to
f59140f
Compare
This should be good as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JuliaNLSolvers/NLsolve.jl#287
Needs #297 to go in first
Fixes #260
Summary
TODOs
Exciting Mixing Update Rule for Broyden