-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend WorkPrecisionSet to DDE problems #7
Conversation
Would a better way of handling this be to make both it and |
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
=======================================
Coverage 95.98% 95.98%
=======================================
Files 7 7
Lines 7172 7172
=======================================
Hits 6884 6884
Misses 288 288
Continue to review full report at Codecov.
|
I like your idea. The only problem I see is that this type structure might not go well with SciML/DelayDiffEq.jl#29. Another alternative would be to introduce a new abstract supertype for all these problems, but I'm not completely sure about the (dis)advantages of this approach. |
I am thinking that everything goes under |
Yeah, separating stochastic and deterministic problems is the best approach, I guess. I'm just slightly confused how AbstractDDEProblem would fit in that type hierarchy, considering that it could be both stochastic and deterministic. Wouldn't this require two different subtypes such as AbstractDDEProblem and AbstractSDDEProblem? But maybe it's not necessary to discuss that now... Anyway, I guess I can close this issue since we should rather change the current type hierarchy? |
Just add AbstractDAEProblem to the deterministic dispatches here and we can merge. We can discuss better use of the type hierarchy in another issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge when tests pass
I just noticed that currently no DDE benchmarks can be performed since no WorkPrecisionSet can be created for DDE problems. It seems this issue is caused by the restructuring in 8de789c#diff-826047b6175ac9aca7e1958367322880.