Update documentation of save_start and save_end
#977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+784
to
+785
| as the final timepoint. This setting is overridden by other saving settings when set to | ||
| `false`. Defaults to |
There was a problem hiding this comment.
That shouldn't be the case. save_start and save_end should be concrete and overriding in that sense. The solution here isn't to document a current bug.
There was a problem hiding this comment.
That's on me then; I interpreted SciML/OrdinaryDiffEq.jl#1842 (comment) to mean that the current behaviour should be documented. I'll mark both PRs for this as WIP.
Let's discuss this in more detail in that issue to keep everything centralised.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SciML/OrdinaryDiffEq.jl#1842
A proposal to clarify the complicated current behaviour of
save_startandsave_endin the documentation.