-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add split screen support #171
base: sc
Are you sure you want to change the base?
Conversation
Wow, that looks great! I'll try to test it in the coming weeks. |
vector/src/main/java/im/vector/app/features/settings/labs/VectorSettingsLabsFragment.kt
Show resolved
Hide resolved
…S_LABS_ENABLE_MULTICHAT
Just did some testing, initial thoughts: Don't know what to expect from non-tablets, but if I enable tablet mode on my Android 11 phone and do the following:
Then it gets me to my launcher instead back to the room list. On my Android 11 tablet, it behaves the same as with my phone. Could it be a problem of my custom ROM not being configured properly to support these features, or is Android 11 too old? On a foldable emulator with Android 13, split screen works, but I haven't gotten the windowed mode to work, is there a system setting that I need to enable? |
I've tested the feature on my samsung tab s7 with android 13, it works flawlessly; however using my phone (MIUI13, an custom ROM with android 12 inside) it doesn't work well (as multiple windows are not well supported on phone devices). Thus I might think that it's well to hide it in phone devices. Furthermore, I'll test the feature with some more tablet devices, as in google's guide there are not major changes done after android 10. |
Any update on this? |
recently I'm working on this approach seems that google thinks it's better than multi window approach. |
With android's multi windows support, it's easy to split two activities into two windows, which benefits tablet users.
Screen shots:
also I provided multi chat windows option for windowed mode android (like samsung's DeX mode)
Those options are opt-in by default for compatibility.
reference: https://developer.android.com/guide/topics/large-screens/multi-window-support